[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 04/16] block: Move filename_decompose to blo
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC PATCH 04/16] block: Move filename_decompose to block.c |
Date: |
Wed, 27 Jan 2016 09:07:54 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 01/26/2016 03:38 AM, Fam Zheng wrote:
> With the return value decoupled from VMDK, it can be reused by other block
> code.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> block.c | 40 ++++++++++++++++++++++++++++++++++++++++
> block/vmdk.c | 40 ----------------------------------------
> include/block/block.h | 2 ++
> 3 files changed, 42 insertions(+), 40 deletions(-)
>
> +++ b/block.c
> @@ -144,6 +144,46 @@ int path_is_absolute(const char *path)
> #endif
> }
>
> +int filename_decompose(const char *filename, char *path, char *prefix,
> + char *postfix, size_t buf_len, Error **errp)
> +{
> + const char *p, *q;
> +
> + if (filename == NULL || !strlen(filename)) {
> + error_setg(errp, "No filename provided");
> + return -EINVAL;
> + }
> + p = strrchr(filename, '/');
> + if (p == NULL) {
> + p = strrchr(filename, '\\');
> + }
I know this is just code motion, but it feels like it does the wrong
thing on Unix boxes (trying too hard to appease Windows boxes). Is that
something that needs to be independently addressed?
But as for this patch, the code motion is fine.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC PATCH 00/16] Qemu Bit Map (QBM) - an overlay format for persistent dirty bitmap, Fam Zheng, 2016/01/26
- [Qemu-devel] [RFC PATCH 01/16] doc: Add QBM format specification, Fam Zheng, 2016/01/26
- [Qemu-devel] [RFC PATCH 02/16] block: Set dirty before doing write, Fam Zheng, 2016/01/26
- [Qemu-devel] [RFC PATCH 03/16] block: Allow .bdrv_close callback to release dirty bitmaps, Fam Zheng, 2016/01/26
- [Qemu-devel] [RFC PATCH 04/16] block: Move filename_decompose to block.c, Fam Zheng, 2016/01/26
- Re: [Qemu-devel] [RFC PATCH 04/16] block: Move filename_decompose to block.c,
Eric Blake <=
- [Qemu-devel] [RFC PATCH 05/16] block: Make bdrv_get_cluster_size public, Fam Zheng, 2016/01/26
- [Qemu-devel] [RFC PATCH 06/16] block: Introduce bdrv_dirty_bitmap_set_persistent, Fam Zheng, 2016/01/26
- [Qemu-devel] [RFC PATCH 07/16] block: Only swap non-persistent dirty bitmaps, Fam Zheng, 2016/01/26
- [Qemu-devel] [RFC PATCH 08/16] qmp: Add optional parameter "persistent" in block-dirty-bitmap-add, Fam Zheng, 2016/01/26
- [Qemu-devel] [RFC PATCH 09/16] qmp: Add block-dirty-bitmap-set-persistent, Fam Zheng, 2016/01/26
- [Qemu-devel] [RFC PATCH 11/16] qapi: Add "qbm" as a generic cow format driver, Fam Zheng, 2016/01/26
- [Qemu-devel] [RFC PATCH 10/16] qbm: Implement format driver, Fam Zheng, 2016/01/26
- [Qemu-devel] [RFC PATCH 12/16] iotests: Add qbm format to 041, Fam Zheng, 2016/01/26
- [Qemu-devel] [RFC PATCH 13/16] iotests: Add qbm to case 097, Fam Zheng, 2016/01/26