Re: [Qemu-devel] [PATCH] virtio-pci: call pci reset variant when guest clears status.

[Michael S. Tsirkin]

On Wed, Jan 27, 2016 at 03:04:49PM +0100, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <address@hidden>

Sure - but why not rework all callers?

> ---
>  hw/virtio/virtio-pci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
> index 94667e6..2f5742c 100644
> --- a/hw/virtio/virtio-pci.c
> +++ b/hw/virtio/virtio-pci.c
> @@ -47,6 +47,7 @@
>  
>  static void virtio_pci_bus_new(VirtioBusState *bus, size_t bus_size,
>                                 VirtIOPCIProxy *dev);
> +static void virtio_pci_reset(DeviceState *qdev);
>  
>  /* virtio device */
>  /* DeviceState to VirtIOPCIProxy. For use off data-path. TODO: use QOM. */
> @@ -1351,8 +1352,7 @@ static void virtio_pci_common_write(void *opaque, 
> hwaddr addr,
>          }
>  
>          if (vdev->status == 0) {
> -            virtio_reset(vdev);
> -            msix_unuse_all_vectors(&proxy->pci_dev);
> +            virtio_pci_reset(DEVICE(proxy));
>          }
>  
>          break;
> -- 
> 1.8.3.1