Re: [Qemu-devel] [PATCH RFC 5/7] filter-buffer: Accept zero interval

[Hailiang Zhang]

On 2016/1/25 13:19, Jason Wang wrote:
> On 01/22/2016 04:36 PM, zhanghailiang wrote:
> > We may want to accept zero interval when VM FT solutions like MC
> > or COLO use this filter to release packets on demand.
> >
> > Signed-off-by: zhanghailiang <address@hidden>
> > Reviewed-by: Yang Hongyang <address@hidden>
> > ---
> >   net/filter-buffer.c | 10 ----------
> >   1 file changed, 10 deletions(-)
>
> Looks a independent patch of this rfc series.

The interval of the default filter is zero, without this patch,
there will be an error report.

> > diff --git a/net/filter-buffer.c b/net/filter-buffer.c
> > index 57be149..12e0c87 100644
> > --- a/net/filter-buffer.c
> > +++ b/net/filter-buffer.c
> > @@ -103,16 +103,6 @@ static void filter_buffer_setup(NetFilterState *nf, Error 
> > **errp)
> >   {
> >       FilterBufferState *s = FILTER_BUFFER(nf);
> >
> > -    /*
> > -     * We may want to accept zero interval when VM FT solutions like MC
> > -     * or COLO use this filter to release packets on demand.
> > -     */
> > -    if (!s->interval) {
> > -        error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "interval",
> > -                   "a non-zero interval");
> > -        return;
> > -    }
> > -
> >       s->incoming_queue = qemu_new_net_queue(qemu_netfilter_pass_to_next, nf);
> >       if (s->interval) {
> >           timer_init_us(&s->release_timer, QEMU_CLOCK_VIRTUAL,
>
>
> .