Re: [Qemu-devel] [PATCH 0/5] target-i386: kvm: Increase MSR entry array limits, check for array overrun

[Eduardo Habkost]

On Wed, Dec 16, 2015 at 10:38:25PM +0100, Paolo Bonzini wrote:
> 
> 
> On 16/12/2015 20:06, Eduardo Habkost wrote:
> > We are dangerously close to the array limits in kvm_put_msrs()
> > and kvm_get_msrs(): with the default mcg_cap configuration, we
> > can set up to 148 MSRs in kvm_put_msrs(), and if we allow mcg_cap
> > to be changed, we can write up to 236 MSRs[1].
> > 
> > This series changes the code to allocate a buffer once per VCPU,
> > increase buffer size to 4096 bytes (that can hold up to 255 MSR
> > entries), and check array limits before appending new entries.
> 
> Thanks, it's a good improvement.
> 
> Reviewed-by: Paolo Bonzini <address@hidden>

Thanks, applied to x86 tree.

-- 
Eduardo