[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] char: fix parameter name / type in BSD codepath
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] char: fix parameter name / type in BSD codepath |
Date: |
Fri, 22 Jan 2016 18:03:27 +0000 |
You typoed the qemu-devel address...
thanks
-- PMM
On 22 January 2016 at 17:35, Daniel P. Berrange <address@hidden> wrote:
> The BSD impl of qemu_chr_open_pp_fd had mis-declared
> its parameter type as ChardevBackend instead of
> ChardevCommon. It had also mistakenly used the variable
> name 'common' instead of 'backend'.
>
> Tested-by: Sean Bruno <address@hidden>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> qemu-char.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index e133f4f..aa2e660 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -1835,12 +1835,12 @@ static int pp_ioctl(CharDriverState *chr, int cmd,
> void *arg)
> }
>
> static CharDriverState *qemu_chr_open_pp_fd(int fd,
> - ChardevBackend *backend,
> + ChardevCommon *backend,
> Error **errp)
> {
> CharDriverState *chr;
>
> - chr = qemu_chr_alloc(common, errp);
> + chr = qemu_chr_alloc(backend, errp);
> if (!chr) {
> return NULL;
> }
> --
> 2.5.0
>
- Re: [Qemu-devel] [PATCH] char: fix parameter name / type in BSD codepath,
Peter Maydell <=