[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v11 3/7] hw/ptimer: Update .delta on period/freq cha
From: |
Dmitry Osipenko |
Subject: |
[Qemu-devel] [PATCH v11 3/7] hw/ptimer: Update .delta on period/freq change |
Date: |
Thu, 21 Jan 2016 22:03:46 +0300 |
Delta value must be updated on period/freq change, otherwise running timer
would be restarted (counter reloaded with old delta). Only m68k/mcf520x
and arm/arm_timer devices are currently doing freq change correctly, i.e.
stopping the timer. Perform delta update to fix affected devices and
eliminate potential further mistakes.
Signed-off-by: Dmitry Osipenko <address@hidden>
Reviewed-by: Peter Crosthwaite <address@hidden>
---
hw/core/ptimer.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/core/ptimer.c b/hw/core/ptimer.c
index cb50d30..904a77b 100644
--- a/hw/core/ptimer.c
+++ b/hw/core/ptimer.c
@@ -189,6 +189,7 @@ void ptimer_stop(ptimer_state *s)
/* Set counter increment interval in nanoseconds. */
void ptimer_set_period(ptimer_state *s, int64_t period)
{
+ s->delta = ptimer_get_count(s);
s->period = period;
s->period_frac = 0;
if (s->enabled) {
@@ -200,6 +201,7 @@ void ptimer_set_period(ptimer_state *s, int64_t period)
/* Set counter frequency in Hz. */
void ptimer_set_freq(ptimer_state *s, uint32_t freq)
{
+ s->delta = ptimer_get_count(s);
s->period = 1000000000ll / freq;
s->period_frac = (1000000000ll << 32) / freq;
if (s->enabled) {
--
2.7.0
- [Qemu-devel] [PATCH v11 0/7] PTimer fixes/features and ARM MPTimer conversion, Dmitry Osipenko, 2016/01/21
- [Qemu-devel] [PATCH v11 3/7] hw/ptimer: Update .delta on period/freq change,
Dmitry Osipenko <=
- [Qemu-devel] [PATCH v11 1/7] hw/ptimer: Fix issues caused by the adjusted timer limit value, Dmitry Osipenko, 2016/01/21
- [Qemu-devel] [PATCH v11 4/7] hw/ptimer: Support "on the fly" timer mode switch, Dmitry Osipenko, 2016/01/21
- [Qemu-devel] [PATCH v11 2/7] hw/ptimer: Perform counter wrap around if timer already expired, Dmitry Osipenko, 2016/01/21
- [Qemu-devel] [PATCH v11 6/7] hw/ptimer: Legalize running with delta = load = 0 and abort on period = 0, Dmitry Osipenko, 2016/01/21
- [Qemu-devel] [PATCH v11 7/7] arm_mptimer: Convert to use ptimer, Dmitry Osipenko, 2016/01/21