Re: [Qemu-devel] [PATCH v2] gdb: provide the name of the architecture in the target.xml

[Cornelia Huck]

On Thu, 21 Jan 2016 17:17:05 +0100
Christian Borntraeger <address@hidden> wrote:

> On 01/15/2016 03:18 PM, Peter Maydell wrote:
> > On 14 January 2016 at 14:27, Christian Borntraeger
> > <address@hidden> wrote:
> >> Ping?
> >>
> >> On 12/03/2015 01:14 PM, Christian Borntraeger wrote:
> >>> From: David Hildenbrand <address@hidden>
> >>>
> >>> This patch provides the name of the architecture in the target.xml
> >>> if available.
> >>>
> >>> This allows the remote gdb to detect the target architecture on its
> >>> own - so there is no need to specify it manually (e.g. if gdb is
> >>> started without a binary) using "set arch *arch_name*".
> >>>
> >>> The name of the architecture is provided by a callback that can
> >>> be implemented by all architectures. The arm implementation has
> >>> special handling for iwmmxt and returns arm otherwise. This can
> >>> be extended if necessary.
> >>>
> >>> Signed-off-by: David Hildenbrand <address@hidden>
> >>> Acked-by: Cornelia Huck <address@hidden>
> >>> Signed-off-by: Christian Borntraeger <address@hidden>
> >>> [rework to use a callback]
> >>> ---
> >>> v1->v2: replace the fixed string with a callback
> >>>
> >>>  gdbstub.c                   | 21 ++++++++++++++-------
> >>>  include/qom/cpu.h           |  3 +++
> >>>  target-arm/cpu.c            | 12 ++++++++++++
> >>>  target-arm/cpu64.c          |  6 ++++++
> >>>  target-ppc/translate_init.c | 10 ++++++++++
> >>>  target-s390x/cpu.c          |  6 ++++++
> >>>  6 files changed, 51 insertions(+), 7 deletions(-)
> > 
> > Reviewed-by: Peter Maydell <address@hidden>
> > 
> > (at least for the generic and ARM related bits).
> 
> Ok, so I will take that and send it via the s390/kvm tree?
> Well, Conny will probably do the next round.

Will do, unless somebody objects.