[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] Add optionrom compatible with fw_cfg DMA ver
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] Add optionrom compatible with fw_cfg DMA version |
|
Date: |
Thu, 21 Jan 2016 10:02:24 +0000 |
|
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Tue, Jan 19, 2016 at 01:11:47PM +0100, Gerd Hoffmann wrote:
> > If you really think they should be merged, I'd even propose to
> > merge the ASM version onto the C version (convert this patch into
> > linuxboot.S). This slightly improves readability.
>
> Fully agree. I'm personally fine with having two roms, but when merging
> them into one we surely should ditch the fw_cfg asm macros and go with
> something more maintainable.
There is no technical requirement for a unified linuxboot ROM. If there
is no disadvantage to having 2 ROMs then let's stick to Marc's approach.
Stefan
signature.asc
Description: PGP signature