[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 04/17] crypto: add support for generating ini
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v2 04/17] crypto: add support for generating initialization vectors |
Date: |
Thu, 21 Jan 2016 15:51:37 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, 01/20 17:38, Daniel P. Berrange wrote:
> +static int qcrypto_ivgen_essiv_init(QCryptoIVGen *ivgen,
> + const uint8_t *key, size_t nkey,
> + Error **errp)
> +{
> + uint8_t *salt;
> + size_t nhash;
> + QCryptoIVGenESSIV *essiv = g_new0(QCryptoIVGenESSIV, 1);
> +
> + nhash = qcrypto_hash_digest_len(ivgen->hash);
> + /* Salt must be larger of hash size or key size */
> + salt = g_new0(uint8_t, nhash > nkey ? nhash : nkey);
> +
> + if (qcrypto_hash_bytes(ivgen->hash, (const gchar *)key, nkey,
> + &salt, &nhash,
> + errp) < 0) {
> + g_free(essiv);
> + return -1;
> + }
> +
> + essiv->cipher = qcrypto_cipher_new(ivgen->cipher,
> + QCRYPTO_CIPHER_MODE_ECB,
> + salt, nkey,
> + errp);
> + if (!essiv->cipher) {
> + g_free(essiv);
> + g_free(salt);
> + return -1;
> + }
> +
> + g_free(salt);
> + ivgen->private = essiv;
> +
> + return 0;
> +}
> +
> +static int qcrypto_ivgen_essiv_calculate(QCryptoIVGen *ivgen,
> + uint64_t sector,
> + uint8_t *iv, size_t niv,
> + Error **errp)
> +{
> + QCryptoIVGenESSIV *essiv = ivgen->private;
> + size_t ndata = qcrypto_cipher_get_block_len(ivgen->cipher);
> + uint8_t *data = g_new(uint8_t, ndata);
> +
> + sector = cpu_to_le64((uint32_t)sector);
Why casting to 32 bit?
> + memcpy(data, (uint8_t *)§or, ndata);
> + if (sizeof(sector) < ndata) {
> + memset(data + sizeof(sector), 0, ndata - sizeof(sector));
> + }
> +
> + if (qcrypto_cipher_encrypt(essiv->cipher,
> + data,
> + data,
> + ndata,
> + errp) < 0) {
> + g_free(data);
> + return -1;
> + }
> +
> + if (ndata > niv) {
> + ndata = niv;
> + }
> + memcpy(iv, data, ndata);
> + if (ndata < niv) {
> + memset(iv + ndata, 0, niv - ndata);
> + }
> + g_free(data);
> + return 0;
> +}
> +
> +static void qcrypto_ivgen_essiv_cleanup(QCryptoIVGen *ivgen)
> +{
> + QCryptoIVGenESSIV *essiv = ivgen->private;
> +
> + qcrypto_cipher_free(essiv->cipher);
> + g_free(essiv);
> +}
> +
> +
> +struct QCryptoIVGenDriver qcrypto_ivgen_essiv = {
> + qcrypto_ivgen_essiv_init,
It'd be more readable to explicitly write
.init = qcrypto_ivgen_essiv_init,
.calculate = ...,
.cleanup = ...
but it is fine since there are only three operations now.
> + qcrypto_ivgen_essiv_calculate,
> + qcrypto_ivgen_essiv_cleanup,
> +};
> +
- Re: [Qemu-devel] [PATCH v2 02/17] crypto: add cryptographic random byte source, (continued)
- [Qemu-devel] [PATCH v2 01/17] crypto: ensure qcrypto_hash_digest_len is always defined, Daniel P. Berrange, 2016/01/20
- [Qemu-devel] [PATCH v2 03/17] crypto: add support for PBKDF2 algorithm, Daniel P. Berrange, 2016/01/20
- [Qemu-devel] [PATCH v2 08/17] block: add flag to indicate that no I/O will be performed, Daniel P. Berrange, 2016/01/20
- [Qemu-devel] [PATCH v2 09/17] qemu-img/qemu-io: don't prompt for passwords if not required, Daniel P. Berrange, 2016/01/20
- [Qemu-devel] [PATCH v2 04/17] crypto: add support for generating initialization vectors, Daniel P. Berrange, 2016/01/20
- Re: [Qemu-devel] [PATCH v2 04/17] crypto: add support for generating initialization vectors,
Fam Zheng <=
- [Qemu-devel] [PATCH v2 05/17] crypto: add support for anti-forensic split algorithm, Daniel P. Berrange, 2016/01/20
- [Qemu-devel] [PATCH v2 06/17] crypto: add block encryption framework, Daniel P. Berrange, 2016/01/20
- [Qemu-devel] [PATCH v2 07/17] crypto: implement the LUKS block encryption format, Daniel P. Berrange, 2016/01/20
- [Qemu-devel] [PATCH v2 13/17] qcow: make encrypt_sectors encrypt in place, Daniel P. Berrange, 2016/01/20
- [Qemu-devel] [PATCH v2 11/17] qcow2: make qcow2_encrypt_sectors encrypt in place, Daniel P. Berrange, 2016/01/20
- [Qemu-devel] [PATCH v2 14/17] qcow: convert QCow to use QCryptoBlock for encryption, Daniel P. Berrange, 2016/01/20