[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH] vfio: Add sysfsdev property for pci & platf

From: P J P
Subject: Re: [Qemu-devel] [RFC PATCH] vfio: Add sysfsdev property for pci & platform
Date: Thu, 21 Jan 2016 12:39:34 +0530 (IST)

+-- On Wed, 20 Jan 2016, Alex Williamson wrote --+
| > > +            error_printf("Warning : Device at %s is known to cause
| > > system instability issues during option rom execution. Proceeding
| > > anyway since user specified romfile\n",
| > > +                         vdev->vbasedev.name);
| > 
| > This error message should really be split across lines like
| > the original code was. Likewise for other cases in this patch
| the source to find an error message, it should work.  Breaking printed
| error messages at arbitrary lengths to fit an 80 column window makes
| that more difficult.  Is there sufficient passion for a hard 80 column
| limit on printed strings in QEMU to ignore that useful property?

  I'd say +1 for breaking it at 80'th column. IMO it helps with readability in 
editor or tools like less(1). As for grep, it can still work with a 
substring/pattern from the error message.

Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F

reply via email to

[Prev in Thread] Current Thread [Next in Thread]