Re: [Qemu-devel] [PATCH 02/10] virtio: move allocation to virtqueue_pop/vring_pop

[Paolo Bonzini]

On 19/01/2016 13:22, Cornelia Huck wrote:
> > The patch is pretty large, but changes to each device are testable
> > more or less independently.  Splitting it would mostly add churn.
> 
> Would it help to add a no-frills virtqueue_pop() version that simply
> allocates the base VirtQueueElement and use a _size() variant for those
> callers that want an extended structure?

Not too much, the churn mostly comes from the VQE* being returned from
virtqueue_pop, rather than passed to it.

> assert(sz >= sizeof(VirtQueueElement));

Good idea.

Paolo