[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v1 05/15] crypto: add block encryption framework

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v1 05/15] crypto: add block encryption framework
Date: Mon, 18 Jan 2016 12:48:56 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0

On 01/14/2016 05:16 AM, Daniel P. Berrange wrote:

>>> +# @qcowaes: QCow/QCow2 built-in AES-CBC encryption. Do not use
>>> +#
>> Well, the only reason to use it would be to read data off an old
>> insecurely-encrypted qcow2 file; so maybe it should read "Do not use on
>> new files"
> Yep
>>> +# Since: 2.6
>>> +##
>>> +{ 'enum': 'QCryptoBlockFormat',
>>> +#  'prefix': 'QCRYPTO_BLOCK_FORMAT',
>>> +  'data': ['qcowaes']}
>> Would 'qcow-aes' be any easier to read?
> Or just shorten to 'qcow' perhaps ?

Or maybe 'old-qcow' to emphasize that it is old?  At this point, we're
painting the bikeshed, so I'll live with whatever you like.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]