[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-arm] [PATCH] cadence_gem: fix buffer overflow
From: |
Alistair Francis |
Subject: |
Re: [Qemu-devel] [Qemu-arm] [PATCH] cadence_gem: fix buffer overflow |
Date: |
Fri, 15 Jan 2016 16:20:50 -0800 |
On Fri, Jan 15, 2016 at 12:06 AM, P J P <address@hidden> wrote:
> +-- On Thu, 14 Jan 2016, Peter Crosthwaite wrote --+
> | I guess QEMU needs the whole packet before handing off to the net layer and
> | the assumption is that the packet is always within 2048. The easiest
> | solution is to realloc the buffer as it goes with the increasing sizes.
>
> Yes, I was considering increasing buffer size with view of the jumbo
> packets. In gem_transmit(), 'tx_desc_get_length' returns length masked by
> DESC_1_LENGTH(=0x1FFF=8191) bytes. But thought dynamic allocation might lead
> to excessive buffer allocation, not sure how constrained the Xilinx platform
> is for memory.
Won't the allocation/reallocation happen on the host?
Thanks,
Alistair
>
> --
> - P J P
> 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
>
Re: [Qemu-devel] [PATCH] cadence_gem: fix buffer overflow, P J P, 2016/01/14
Re: [Qemu-devel] [PATCH] cadence_gem: fix buffer overflow, Jason Wang, 2016/01/14
Re: [Qemu-devel] [PATCH] cadence_gem: fix buffer overflow, Jason Wang, 2016/01/18