Re: [Qemu-devel] [PATCH v3 2/5] sockets: remove use of QemuOpts from socket_listen

[Eric Blake]

On 01/11/2016 06:17 AM, Daniel P. Berrange wrote:
> The socket_listen method accepts a QAPI SocketAddress object
> which it then turns into QemuOpts before calling the
> inet_listen_opts/unix_listen_opts helper methods. By
> converting the latter to use QAPI SocketAddress directly,
> the QemuOpts conversion step can be eliminated
> 
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  util/qemu-sockets.c | 154 
> +++++++++++++++++++++++++++++++++-------------------
>  1 file changed, 97 insertions(+), 57 deletions(-)
> 

> + *
> + * NB, this matrix is only about getting the neccessary results

s/neccessary/necessary/

With the typo fix,
Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature