[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] docs/qapi-code-gen.txt: Fix simple union intros
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH] docs/qapi-code-gen.txt: Fix simple union introspection example |
|
Date: |
Fri, 15 Jan 2016 10:25:01 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 01/14/2016 08:13 AM, Markus Armbruster wrote:
>> The implicit tag member is named "type", not "kind". Screwed up in
>> commit 39a1815.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> docs/qapi-code-gen.txt | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Eric Blake <address@hidden>
>
> However, there's other errors in the documentation (we haven't kept it
> up-to-date with recent churn in the generator), so maybe it's better to
> fix all of them at once. See my Subset E series:
> https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg03863.html
> https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg00410.html
Feel free to fold my patch into yours.
> (I'll probably have to send a v9 of the series, but wanted to see if you
> had any comments on v8 first)
In my review queue.