[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 for v2.3.0] fw_cfg: add check to validate cur
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 for v2.3.0] fw_cfg: add check to validate current entry value |
Date: |
Mon, 11 Jan 2016 13:28:06 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 11/01/2016 08:23, P J P wrote:
> Hello,
>
> +-- On Wed, 6 Jan 2016, P J P wrote --+
> | When processing firmware configurations, an OOB r/w access occurs
> | if 's->cur_entry' is set to be invalid(FW_CFG_INVALID=0xffff).
> | Add a check to validate 's->cur_entry' to avoid such access.
> |
> | Reported-by: Donghai Zdh <address@hidden>
> | Signed-off-by: Prasad J Pandit <address@hidden>
> | ---
> | hw/nvram/fw_cfg.c | 12 ++++++++----
> | 1 file changed, 8 insertions(+), 4 deletions(-)
> |
> | Updated as per review in
> | -> https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg00398.html
>
>
> -> https://patchwork.ozlabs.org/patch/563706/
>
> Ping...! Does it look okay? (just checking)
Yes, it looks good.
Paolo