[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 07/24] net/vmxnet3: return 1 on device activation fai
From: |
Jason Wang |
Subject: |
[Qemu-devel] [PULL 07/24] net/vmxnet3: return 1 on device activation failure |
Date: |
Mon, 11 Jan 2016 13:30:58 +0800 |
From: Miao Yan <address@hidden>
When reading device status, 0 means device is successfully
activated and 1 means error.
This behavior can be observed by the following steps:
1) run a Linux distro on esxi server (5.5+)
2) modify vmxnet3 Linux driver to give it an invalid
address to 'adapter->shared_pa' which is the
shared memory for guest/host communication
This will trigger device activation failure and kernel
log will have the following message:
[ 7138.403256] vmxnet3 0000:03:00.0 eth1: Failed to activate dev: error 1
So return 1 on device activation failure instead of -1;
Signed-off-by: Miao Yan <address@hidden>
Reviewed-by: Dmitry Fleytman <address@hidden>
Signed-off-by: Jason Wang <address@hidden>
---
hw/net/vmxnet3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
index 9c1adfc..8a992d3 100644
--- a/hw/net/vmxnet3.c
+++ b/hw/net/vmxnet3.c
@@ -1662,7 +1662,7 @@ static uint64_t vmxnet3_get_command_status(VMXNET3State
*s)
switch (s->last_command) {
case VMXNET3_CMD_ACTIVATE_DEV:
- ret = (s->device_active) ? 0 : -1;
+ ret = (s->device_active) ? 0 : 1;
VMW_CFPRN("Device active: %" PRIx64, ret);
break;
--
2.5.0
- [Qemu-devel] [PULL 00/24] Net patches, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 01/24] net/vmxnet3: fix a build error when enabling debug output, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 02/24] net/vmxnet3: use %zu for size_t in printf, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 03/24] net/vmxnet3: fix debug macro pattern for vmxnet3, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 04/24] net/vmxnet3: remove redundant VMW_SHPRN(...) definition, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 05/24] net: vmxnet3: avoid memory leakage in activate_device, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 06/24] MAINTAINERS: Add an entry for the net/slirp.c file, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 07/24] net/vmxnet3: return 1 on device activation failure,
Jason Wang <=
- [Qemu-devel] [PULL 08/24] net/vmxnet3: return correct value for VMXNET3_CMD_GET_DID_* command, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 09/24] net/vmxnet3: return correct value for VMXNET3_CMD_GET_DEV_EXTRA_INFO, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 10/24] net/vmxnet3: return 0 on unknown command, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 11/24] net/vmxnet3: rename VMXNET3_DEVICE_VERSION to VMXNET3_UPT_REVISION, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 12/24] net/dump: fix nfds->filename leak, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 13/24] net/filter: fix nf->netdev_id leak, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 14/24] vmxnet3: Change offsets of msi/msix pci capabilities, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 15/24] vmxnet3: Change the offset of the MSIX PBA table, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 16/24] vmxnet3: Introduce 'x-old-msi-offsets' back-compat property, Jason Wang, 2016/01/11
- [Qemu-devel] [PULL 17/24] vmxnet3: coding: Introduce VMXNET3Class, Jason Wang, 2016/01/11