[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/6] virtio: drop the virtio_needs_swap() helper
From: |
Greg Kurz |
Subject: |
Re: [Qemu-devel] [PATCH 3/6] virtio: drop the virtio_needs_swap() helper |
Date: |
Fri, 8 Jan 2016 10:16:56 +0100 |
On Thu, 7 Jan 2016 20:55:50 +0100
Laurent Vivier <address@hidden> wrote:
>
>
> On 07/01/2016 12:32, Greg Kurz wrote:
> > It is not used anymore.
> >
> > Signed-off-by: Greg Kurz <address@hidden>
> > ---
> > include/hw/virtio/virtio-access.h | 9 ---------
> > 1 file changed, 9 deletions(-)
> >
> > diff --git a/include/hw/virtio/virtio-access.h
> > b/include/hw/virtio/virtio-access.h
> > index 8aec843c8ff3..a01fff2e51d7 100644
> > --- a/include/hw/virtio/virtio-access.h
> > +++ b/include/hw/virtio/virtio-access.h
> > @@ -143,15 +143,6 @@ static inline uint64_t virtio_ldq_p(VirtIODevice
> > *vdev, const void *ptr)
> > }
> > }
> >
> > -static inline bool virtio_needs_swap(VirtIODevice *vdev)
> > -{
> > -#ifdef HOST_WORDS_BIGENDIAN
> > - return virtio_access_is_big_endian(vdev) ? false : true;
> > -#else
> > - return virtio_access_is_big_endian(vdev) ? true : false;
> > -#endif
> > -}
> > -
>
> I think you can move this to PATCH 1/6 too.
>
I usually prefer to separate cleanup from functional changes, but
indeed this one is trivial... I'll do that and we will see if it
helps when I re-post.
> > static inline uint16_t virtio_tswap16(VirtIODevice *vdev, uint16_t s)
> > {
> > #ifdef HOST_WORDS_BIGENDIAN
> >
> >
>
- Re: [Qemu-devel] [PATCH 1/6] virtio-net: use the backend cross-endian capabilities, (continued)
[Qemu-devel] [PATCH 2/6] Revert "vhost-net: tell tap backend about the vnet endianness", Greg Kurz, 2016/01/07
[Qemu-devel] [PATCH 3/6] virtio: drop the virtio_needs_swap() helper, Greg Kurz, 2016/01/07
[Qemu-devel] [PATCH 4/6] virtio: move cross-endian helper to vhost, Greg Kurz, 2016/01/07
[Qemu-devel] [PATCH 6/6] virtio: optimize virtio_access_is_big_endian() for little-endian targets, Greg Kurz, 2016/01/07
[Qemu-devel] [PATCH 5/6] vhost: move virtio 1.0 check to cross-endian helper, Greg Kurz, 2016/01/07