[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 20/22] 9pfs: break out generic code from virtio-
|
From: |
Wei Liu |
|
Subject: |
Re: [Qemu-devel] [PATCH 20/22] 9pfs: break out generic code from virtio-9p.{c, h} |
|
Date: |
Thu, 7 Jan 2016 17:16:06 +0000 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Jan 07, 2016 at 10:27:13PM +0530, Aneesh Kumar K.V wrote:
> Wei Liu <address@hidden> writes:
>
> > The vast majority of code in virtio-9p.c is actually generic code.
> > Rename that file to 9p.c and move virtio specific code to
> > virtio-9p-device.c. Rename virtio-9p.h to 9p.h and split out virtio
> > specific code to new virtio-9p.h.
> >
> > Finally fix up virtio-pci.h header file inclusion.
> >
> > Note that V9fsState and V9fsPDU are still tied to virtio at the moment.
> > They will be handled later.
>
> Can you split this to smaller patches as done for others.
>
I'm not sure what you're asking for. IMHO splitting out C and header
file is better done in one single commit.
Wei.
> >
> > Signed-off-by: Wei Liu <address@hidden>
>
> -aneesh
>
- Re: [Qemu-devel] [PATCH 10/22] fsdev: break out 9p-marshal.{c, h} from virtio-9p-marshal.{c, h}, (continued)
- [Qemu-devel] [PATCH 15/22] 9pfs: PDU processing functions should start pdu_ prefix, Wei Liu, 2016/01/05
- [Qemu-devel] [PATCH 22/22] 9pfs: disentangle V9fsState, Wei Liu, 2016/01/05
- [Qemu-devel] [PATCH 18/22] 9pfs: factor out pdu_push_and_notify, Wei Liu, 2016/01/05
- [Qemu-devel] [PATCH 21/22] 9pfs: factor out v9fs_device_{, un}realize_common, Wei Liu, 2016/01/05
- [Qemu-devel] [PATCH 19/22] 9pfs: break out virtio_init_iov_from_pdu, Wei Liu, 2016/01/05
- [Qemu-devel] [PATCH 16/22] 9pfs: make pdu_{, un}marshal proper functions, Wei Liu, 2016/01/05
- [Qemu-devel] [PATCH 20/22] 9pfs: break out generic code from virtio-9p.{c, h}, Wei Liu, 2016/01/05
- Re: [Qemu-devel] [PATCH 20/22] 9pfs: break out generic code from virtio-9p.{c, h}, Aneesh Kumar K.V, 2016/01/07
- Re: [Qemu-devel] [PATCH 20/22] 9pfs: break out generic code from virtio-9p.{c, h},
Wei Liu <=
- Re: [Qemu-devel] [PATCH 20/22] 9pfs: break out generic code from virtio-9p.{c, h}, Aneesh Kumar K.V, 2016/01/07
- Re: [Qemu-devel] [PATCH 20/22] 9pfs: break out generic code from virtio-9p.{c, h}, Greg Kurz, 2016/01/07
- Re: [Qemu-devel] [PATCH 20/22] 9pfs: break out generic code from virtio-9p.{c, h}, Wei Liu, 2016/01/07
- Re: [Qemu-devel] [PATCH 20/22] 9pfs: break out generic code from virtio-9p.{c, h}, Wei Liu, 2016/01/07
[Qemu-devel] [PATCH 17/22] 9pfs: factor out virtio_pdu_{, un}marshal, Wei Liu, 2016/01/05
[Qemu-devel] [PATCH 12/22] 9pfs: use V9fsBlob to transmit xattr, Wei Liu, 2016/01/05
[Qemu-devel] [PATCH 13/22] fsdev: rename virtio-9p-marshal.{c, h} to 9p-iov-marshal.{c, h}, Wei Liu, 2016/01/05
[Qemu-devel] [PATCH 14/22] 9pfs: PDU processing functions don't need to take V9fsState as argument, Wei Liu, 2016/01/05