[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/dma/xilinx_axidma: remove dead code
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] hw/dma/xilinx_axidma: remove dead code |
Date: |
Thu, 7 Jan 2016 11:40:28 +0000 |
On 6 January 2016 at 12:53, Andrew Jones <address@hidden> wrote:
> stream_desc_show() (and DEBUG_ENET) appear to be unused, as the
> function isn't compilable (there are broken PRI format strings).
>
> Signed-off-by: Andrew Jones <address@hidden>
> ---
> hw/dma/xilinx_axidma.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/hw/dma/xilinx_axidma.c b/hw/dma/xilinx_axidma.c
> index b1cfa11356a26..f5ebc1f0e0734 100644
> --- a/hw/dma/xilinx_axidma.c
> +++ b/hw/dma/xilinx_axidma.c
> @@ -177,16 +177,6 @@ static inline int streamid_from_addr(hwaddr addr)
> return sid;
> }
>
> -#ifdef DEBUG_ENET
> -static void stream_desc_show(struct SDesc *d)
> -{
> - qemu_log("buffer_addr = " PRIx64 "\n", d->buffer_address);
> - qemu_log("nxtdesc = " PRIx64 "\n", d->nxtdesc);
> - qemu_log("control = %x\n", d->control);
> - qemu_log("status = %x\n", d->status);
> -}
> -#endif
> -
> static void stream_desc_load(struct Stream *s, hwaddr addr)
> {
> struct SDesc *d = &s->desc;
Applied to target-arm.next, thanks.
-- PMM