[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 17/35] qapi: Drop unused 'kind' for struct/en
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v8 17/35] qapi: Drop unused 'kind' for struct/enum visit |
Date: |
Tue, 5 Jan 2016 17:26:34 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 12/21/2015 10:08 AM, Eric Blake wrote:
> visit_start_struct() and visit_type_enum() had a 'kind' argument
> that was usually set to either the stringized version of the
> corresponding qapi type name, or to NULL (although some clients
> didn't even get that right). But nothing ever used the argument.
> It's even hard to argue that it would be useful in a debugger,
> as a stack backtrace also tells which type is being visited.
>
> Therefore, drop the 'kind' argument as dead.
>
> Signed-off-by: Eric Blake <address@hidden>
>
> ---
> v8: rebase to 'name' motion
> v7: new patch
> +++ b/qapi/qapi-visit-core.c
> @@ -2,6 +2,7 @@
> * Core Definitions for QAPI Visitor Classes
> *
> * Copyright IBM, Corp. 2011
> + * Copyright (C) 2015 Red Hat, Inc.
Hmm (and more of a note to myself): Now that the year has rolled over,
if I have a reason to spin v9, I'll have to remember to update all my
Copyright lines to include 2016.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature