[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 27/35] qapi: Fix command with named empty arg
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH v8 27/35] qapi: Fix command with named empty argument type |
Date: |
Tue, 5 Jan 2016 15:04:27 +0100 |
Hi
On Mon, Dec 21, 2015 at 6:08 PM, Eric Blake <address@hidden> wrote:
> The generator special-cased
> { 'command':'foo', 'data': {} }
> to avoid emitting a visitor variable, but failed to see that
> { 'struct':'NamedEmptyType, 'data': {} }
> { 'command':'foo', 'data':'NamedEmptyType' }
> needs the same treatment. Without a fix to the generator, the
> change to qapi-schema-test.json fails to compile with:
>
> tests/test-qmp-marshal.c: In function ‘qmp_marshal_user_def_cmd0’:
> tests/test-qmp-marshal.c:264:14: error: variable ‘v’ set but not used
> [-Werror=unused-but-set-variable]
> Visitor *v;
> ^
>
> Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
--
Marc-André Lureau
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v8 27/35] qapi: Fix command with named empty argument type,
Marc-André Lureau <=