[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 01/14] block: Add "file" output parameter to
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v4 01/14] block: Add "file" output parameter to block status query functions |
Date: |
Tue, 5 Jan 2016 12:16:51 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, 01/04 22:00, Max Reitz wrote:
> On 24.12.2015 06:50, Fam Zheng wrote:
> > The added parameter can be used to return the BDS pointer which the
> > valid offset is referring to. It's value should be ignored unless
>
> *Its
>
> > BDRV_BLOCK_OFFSET_VALID in ret is set.
> >
> > Until block drivers fill in the right value, let's clear it explicitly
> > right before calling .bdrv_get_block_status.
> >
> > Reviewed-by: Stefan Hajnoczi <address@hidden>
> > Signed-off-by: Fam Zheng <address@hidden>
> > ---
> > block/io.c | 42 ++++++++++++++++++++++++++++--------------
> > block/iscsi.c | 6 ++++--
> > block/mirror.c | 3 ++-
> > block/parallels.c | 2 +-
> > block/qcow.c | 2 +-
> > block/qcow2.c | 2 +-
> > block/qed.c | 3 ++-
> > block/raw-posix.c | 3 ++-
> > block/raw_bsd.c | 3 ++-
> > block/sheepdog.c | 2 +-
> > block/vdi.c | 2 +-
> > block/vmdk.c | 2 +-
> > block/vpc.c | 2 +-
> > block/vvfat.c | 2 +-
> > include/block/block.h | 6 ++++--
> > include/block/block_int.h | 3 ++-
> > qemu-img.c | 7 +++++--
> > 17 files changed, 59 insertions(+), 33 deletions(-)
> >
>
> [...]
>
> > diff --git a/include/block/block.h b/include/block/block.h
> > index db8e096..70b4984 100644
> > --- a/include/block/block.h
> > +++ b/include/block/block.h
>
> The comment explaining BDRV_BLOCK_OFFSET_VALID should be changed
> accordingly (you could also say "fixed", because apparently it wasn't
> always bs->file; sometimes it was bs itself (in case of raw-posix, iscsi
> and sheepdog)).
Yes, good point! Will fix this, and the typo above.
Fam