[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 0/4] Convert to realize()
From: |
Cao jin |
Subject: |
[Qemu-devel] [PATCH v2 0/4] Convert to realize() |
Date: |
Sun, 27 Dec 2015 21:40:36 +0800 |
v2 changelog:
1. separate every supporting function into a single patch
2. Change supporting function type to void, for consistency
3. other fixes as per Stefano`s review
@Stefano: the last patch build failure you feedback:
qemu/hw/xen/xen_pt_config_init.c: In function ‘xen_pt_config_init’:
qemu/hw/xen/xen_pt_config_init.c:2061:42: error: ‘rc’ may be used uninitialized
in this func
I admit it is careless misktake(fixed), but weird thing is, I confirmed
again, it indeed can compile in my environment, the evidence is:
1. every time I make after touching xen_pt_config_init.c, I can see the log:
CC x86_64-softmmu/hw/xen/xen_pt_config_init.o
LINK x86_64-softmmu/qemu-system-x86_64
2. $ readelf -s qemu-system-x86_64 | grep xen_pt_config_init , can got the
symbol
Will the different compiler make the difference?(I am using
gcc (GCC) 4.9.2 20150212 (Red Hat 4.9.2-6))
Cao jin (4):
Add Error **errp for xen_host_pci_device_get()
Add Error **errp for xen_pt_setup_vga()
Add Error **errp for xen_pt_config_init()
Xen PCI passthru: convert to realize()
hw/xen/xen-host-pci-device.c | 102 ++++++++++++++++++++++++-------------------
hw/xen/xen-host-pci-device.h | 5 ++-
hw/xen/xen_pt.c | 73 +++++++++++++++++--------------
hw/xen/xen_pt.h | 5 ++-
hw/xen/xen_pt_config_init.c | 48 ++++++++++----------
hw/xen/xen_pt_graphics.c | 11 ++---
6 files changed, 134 insertions(+), 110 deletions(-)
--
2.1.0
- [Qemu-devel] [PATCH v2 0/4] Convert to realize(),
Cao jin <=