Re: [Qemu-devel] [PATCH v2 08/10] qemu-nbd: don't overlap long option values with short options

[Eric Blake]

On 12/23/2015 10:11 AM, Daniel P. Berrange wrote:
> When defining values for long options, the normal practice is
> to start numbering from 256, to avoid overlap with the range
> of valid values for short options.
> 
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  qemu-nbd.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

> 
> diff --git a/qemu-nbd.c b/qemu-nbd.c
> index 02fdcf1..9898e22 100644
> --- a/qemu-nbd.c
> +++ b/qemu-nbd.c
> @@ -44,12 +44,12 @@
>  #include <pthread.h>
>  
>  #define SOCKET_PATH                "/var/lock/qemu-nbd-%s"
> -#define QEMU_NBD_OPT_CACHE         1
> -#define QEMU_NBD_OPT_AIO           2
> -#define QEMU_NBD_OPT_DISCARD       3
> -#define QEMU_NBD_OPT_DETECT_ZEROES 4
> -#define QEMU_NBD_OPT_OBJECT        5
> -#define QEMU_NBD_OPT_IMAGE_OPTS    6
> +#define QEMU_NBD_OPT_CACHE         256
> +#define QEMU_NBD_OPT_AIO           257
> +#define QEMU_NBD_OPT_DISCARD       258
> +#define QEMU_NBD_OPT_DETECT_ZEROES 259
> +#define QEMU_NBD_OPT_OBJECT        260
> +#define QEMU_NBD_OPT_IMAGE_OPTS    261
>  
>  static NBDExport *exp;
>  static int verbose;
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature