Thanks for helping me, i'll use the patch format suggested by you.
At 2015-12-22 10:06:17, "Fam Zheng" <address@hidden> wrote:
>On Tue, 12/22 09:42, Qinghua Jin wrote:
>> This is an update of patch previously show in msg:
>>
>> http://lists.gnu.org/archive/html/qemu-devel/2015-12/msg03817.html
>
>The patch looks good to me, thanks for submitting the patch! There is only one
>minor comment:
>
>Patch revision note should go after the --- line (or the cover letter if you
>have one) so that it won't be commited into the git log (because it wouldn't be
>informative):
>
> When send system_powerdown to QMP when the vm isn't in RUN_STATE_RUNNING,
> it will be ignored by system. So reply a err msg with the situation.
>
> Signed-off-by: Qinghua Jin <address@hidden>
> ---
>
> This is an update of patch previously show in msg:
>
> http://lists.gnu.org/archive/html/qemu-devel/2015-12/msg03817.html
>
> qmp.c | 7 ++++++-
>
>>
>> When send system_powerdown to QMP when the vm isn't in RUN_STATE_RUNNING,
>> it will be ignored by system. So reply a err msg with the situation.
>>
>> Signed-off-by: Qinghua Jin <address@hidden>
>> ---
>> qmp.c | 7 ++++++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/qmp.c b/qmp.c
>> index 0a1fa19..384df56 100644
>> --- a/qmp.c
>> +++ b/qmp.c
>> @@ -114,8 +114,13 @@ void qmp_system_reset(Error **errp)
>> qemu_system_reset_request();
>> }
>>
>> -void qmp_system_powerdown(Error **erp)
>> +void qmp_system_powerdown(Error **errp)
>> {
>> + if (!runstate_check(RUN_STATE_RUNNING)) {
>> + error_setg(errp,
>> + "Can not powerdown virtual machine as it is not running");
>> + return;
>> + }
>> qemu_system_powerdown_request();
>> }
>>
>> --
>> 2.5.0
>>
>>
>>