[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 5/6] xlnx-zynqmp: Connect the SPI devices
From: |
Alistair Francis |
Subject: |
Re: [Qemu-devel] [PATCH v5 5/6] xlnx-zynqmp: Connect the SPI devices |
Date: |
Fri, 18 Dec 2015 09:17:03 -0800 |
On Thu, Dec 17, 2015 at 3:12 AM, Paolo Bonzini <address@hidden> wrote:
>
>
> On 17/12/2015 12:11, Peter Maydell wrote:
>> > It's a hack and I don't want it to become a sanctioned way to do it.
>> > It's already messing around pretty heavily with qdev internals, see the
>> > line right after QLIST_INSERT_HEAD:
>> >
>> > QLIST_INSERT_HEAD(&dev->child_bus, spi_bus, sibling);
>>
>> Well, that doesn't look good either. I think my point still
>> stands -- we should be providing proper infrastructure at
>> the qdev level to allow SoC container devices to do the
>> things they need to do, not just letting the containers
>> mess with the qdev internals.
>
> I agree completely.
Does anyone have any ideas on how we can do this?
AFAIK there is no way to currently do this, so we need to add
something. What is the preferred way to expose the buses?
Thanks,
Alistair
>
> Paolo
>
- [Qemu-devel] [PATCH v5 2/6] ssi: Move ssi.h into a separate directory, (continued)
- [Qemu-devel] [PATCH v5 2/6] ssi: Move ssi.h into a separate directory, Alistair Francis, 2015/12/16
- [Qemu-devel] [PATCH v5 3/6] xilinx_spips: Separate the state struct into a header, Alistair Francis, 2015/12/16
- [Qemu-devel] [PATCH v5 5/6] xlnx-zynqmp: Connect the SPI devices, Alistair Francis, 2015/12/16
- Re: [Qemu-devel] [PATCH v5 5/6] xlnx-zynqmp: Connect the SPI devices, Paolo Bonzini, 2015/12/16
- Re: [Qemu-devel] [PATCH v5 5/6] xlnx-zynqmp: Connect the SPI devices, Alistair Francis, 2015/12/16
- Re: [Qemu-devel] [PATCH v5 5/6] xlnx-zynqmp: Connect the SPI devices, Peter Maydell, 2015/12/17
- Re: [Qemu-devel] [PATCH v5 5/6] xlnx-zynqmp: Connect the SPI devices, Paolo Bonzini, 2015/12/17
- Re: [Qemu-devel] [PATCH v5 5/6] xlnx-zynqmp: Connect the SPI devices, Peter Maydell, 2015/12/17
- Re: [Qemu-devel] [PATCH v5 5/6] xlnx-zynqmp: Connect the SPI devices, Paolo Bonzini, 2015/12/17
- Re: [Qemu-devel] [PATCH v5 5/6] xlnx-zynqmp: Connect the SPI devices,
Alistair Francis <=
- Re: [Qemu-devel] [PATCH v5 5/6] xlnx-zynqmp: Connect the SPI devices, Paolo Bonzini, 2015/12/18
- Re: [Qemu-devel] [PATCH v5 5/6] xlnx-zynqmp: Connect the SPI devices, Peter Crosthwaite, 2015/12/19
[Qemu-devel] [PATCH v5 4/6] qdev: Add a function to rename busses, Alistair Francis, 2015/12/16
[Qemu-devel] [PATCH v5 6/6] xlnx-ep108: Connect the SPI Flash, Alistair Francis, 2015/12/16