Re: [Qemu-devel] [PATCH v2 16/23] error: Strip trailing '\n' from error string arguments (again)

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 12/17/2015 09:49 AM, Markus Armbruster wrote:
>> Commit 6daf194d, be62a2eb and 312fd5f got rid of a bunch, but they
>> keep coming back.  Tracked down with the Coccinelle semantic patch
>> from commit 312fd5f.
>
> Don't forget to rerun this to pick up stragglers exposed by 1/23 :)

Just two:

qemu-nbd.c:574:76:"Shared device number must be greater than 0\n"
qemu-nbd.c:557:61:"socket path must be absolute\n"

>> Signed-off-by: Markus Armbruster <address@hidden>
>> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
>> Acked-by: Cornelia Huck <address@hidden>
>> Acked-by: Bharata B Rao <address@hidden>
>> Acked-by: Fam Zheng <address@hidden>
>
> If you want to add to the list:
> Reviewed-by: Eric Blake <address@hidden>
>
>> +++ b/hw/s390x/s390-skeys.c
>> @@ -191,8 +191,8 @@ static int qemu_s390_skeys_set(S390SKeysState *ss, 
>> uint64_t start_gfn,
>>      /* Check for uint64 overflow and access beyond end of key data */
>>      if (start_gfn + count > skeydev->key_count || start_gfn + count < 
>> count) {
>>          error_report("Error: Setting storage keys for page beyond the end "
>> -                "of memory: gfn=%" PRIx64 " count=%" PRId64 "\n", start_gfn,
>> -                count);
>> +                     "of memory: gfn=%" PRIx64 " count=%" PRId64,
>> +                     start_gfn, count);
>
> Do we want a separate patch cleaning up 'Error: ' prefixes?

After my Christmas break, in a separate series probably.