Re: [Qemu-devel] [PATCH RFC] qemu-char: add logfile facility to socket backend

[Daniel P. Berrange]

On Thu, Dec 17, 2015 at 01:49:32PM +0100, Paolo Bonzini wrote:
> 
> 
> On 17/12/2015 13:02, Daniel P. Berrange wrote:
> >>> > > 
> >>> > >  $QEMU -chardev socket,host=localhost,port=9000,\
> >>> > >                 server=on,nowait,id-charserial0,\
> >>> > >               logfile=/var/log/libvirt/qemu/test-serial0.log
> >>> > >        -device isa-serial,chardev=charserial0,id=serial0
> >> > 
> >> > Why for socket only?  It would be very useful for stdio and especially 
> >> > vc.
> > This is just an "RFC" so didn't want to spend the time to wire
> > up all of them until I got positive feedback on the idea :-)
> 
> Yes, I think it's fine.  I guess one could do weird things with it such
> as connecting it to a named pipe, but we shouldn't waste time preventing it.

Great, I'll work on a properly complete patch for this then.

> > If its acceptable, then I think it could make sense to just
> > support optional "logfile" on every single backend, except "file"
> 
> Yeah, I'd even wire it in qemu_chr_fe_write, and only prevent it for
> "file" at option parsing time.  Or just allow it for all of them.

Yeah, doing it above the backend driver layer sounds like a nice
simple approach to making it work universally.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|