[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 5/6] xlnx-zynqmp: Connect the SPI devices
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v5 5/6] xlnx-zynqmp: Connect the SPI devices |
Date: |
Thu, 17 Dec 2015 00:24:17 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 16/12/2015 22:45, Alistair Francis wrote:
> +
> + /* Rename each SPI bus after the SPI device to allow the board
> + * to access all of the busses from the SoC.
> + */
> + spi_bus = qdev_get_child_bus(DEVICE(&s->spi[i]), "spi0");
> + snprintf(bus_name, 6, "spi%d", i);
> + qdev_bus_rename(spi_bus, bus_name);
> +
> + /* Add the SPI buses to the SoC child bus */
> + /* FIXME: This causes the later buses to be duplicated in
> + * the SPI devices printout when running qtre.
> + */
> + QLIST_INSERT_HEAD(&dev->child_bus, spi_bus, sibling);
Isn't the SPI bus accessible with something similar to spi[0-5]/spi0,
even without this hack?
In any case, I would prefer qdev_bus_rename to stay in xlnx-zynqmp.c.
Paolo
- [Qemu-devel] [PATCH v5 0/6] Connect the SPI devices to ZynqMP, Alistair Francis, 2015/12/16
- [Qemu-devel] [PATCH v5 1/6] m25p80.c: Add sst25wf080 SPI flash device, Alistair Francis, 2015/12/16
- [Qemu-devel] [PATCH v5 2/6] ssi: Move ssi.h into a separate directory, Alistair Francis, 2015/12/16
- [Qemu-devel] [PATCH v5 3/6] xilinx_spips: Separate the state struct into a header, Alistair Francis, 2015/12/16
- [Qemu-devel] [PATCH v5 5/6] xlnx-zynqmp: Connect the SPI devices, Alistair Francis, 2015/12/16
- Re: [Qemu-devel] [PATCH v5 5/6] xlnx-zynqmp: Connect the SPI devices,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH v5 5/6] xlnx-zynqmp: Connect the SPI devices, Alistair Francis, 2015/12/16
- Re: [Qemu-devel] [PATCH v5 5/6] xlnx-zynqmp: Connect the SPI devices, Peter Maydell, 2015/12/17
- Re: [Qemu-devel] [PATCH v5 5/6] xlnx-zynqmp: Connect the SPI devices, Paolo Bonzini, 2015/12/17
- Re: [Qemu-devel] [PATCH v5 5/6] xlnx-zynqmp: Connect the SPI devices, Peter Maydell, 2015/12/17
- Re: [Qemu-devel] [PATCH v5 5/6] xlnx-zynqmp: Connect the SPI devices, Paolo Bonzini, 2015/12/17
- Re: [Qemu-devel] [PATCH v5 5/6] xlnx-zynqmp: Connect the SPI devices, Alistair Francis, 2015/12/18
- Re: [Qemu-devel] [PATCH v5 5/6] xlnx-zynqmp: Connect the SPI devices, Paolo Bonzini, 2015/12/18
- Re: [Qemu-devel] [PATCH v5 5/6] xlnx-zynqmp: Connect the SPI devices, Peter Crosthwaite, 2015/12/19
[Qemu-devel] [PATCH v5 4/6] qdev: Add a function to rename busses, Alistair Francis, 2015/12/16