[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v0 2/9] cpu: Store CPU typename in MachineSt
From: |
Bharata B Rao |
Subject: |
Re: [Qemu-devel] [RFC PATCH v0 2/9] cpu: Store CPU typename in MachineState |
Date: |
Tue, 15 Dec 2015 14:08:09 +0530 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Dec 14, 2015 at 03:29:49PM -0200, Eduardo Habkost wrote:
> On Thu, Dec 10, 2015 at 11:45:37AM +0530, Bharata B Rao wrote:
> > Storing CPU typename in MachineState lets us to create CPU threads
> > for all architectures in uniform manner from arch-neutral code.
> >
> > TODO: Touching only i386 and spapr targets for now
> >
> > Signed-off-by: Bharata B Rao <address@hidden>
>
> Suggestions:
>
> * Name the field "cpu_base_type" to indicate it is the base CPU
> class name, not the actual CPU class name used when creating
> CPUs.
> * Put it in MachineClass, as it may be useful for code that
> runs before machine->init(), in the future.
Ok.
> * Maybe make it a CPUClass* field instead of a string?
In the current use case, this base cpu type string is being passed
to cpu_generic_init(const char *typename, const char *cpu_model)
to create boot time CPUs with given typename and cpu_mode. So for now
the string makes sense for use case.
Making it CPUClass* would necessiate more changes to cpu_generic_init().
Regards,
Bharata.
[Qemu-devel] [RFC PATCH v0 2/9] cpu: Store CPU typename in MachineState, Bharata B Rao, 2015/12/10
- Re: [Qemu-devel] [RFC PATCH v0 2/9] cpu: Store CPU typename in MachineState, Eduardo Habkost, 2015/12/14
- Re: [Qemu-devel] [RFC PATCH v0 2/9] cpu: Store CPU typename in MachineState,
Bharata B Rao <=
- Re: [Qemu-devel] [RFC PATCH v0 2/9] cpu: Store CPU typename in MachineState, Eduardo Habkost, 2015/12/15
- Re: [Qemu-devel] [RFC PATCH v0 2/9] cpu: Store CPU typename in MachineState, Igor Mammedov, 2015/12/16
- Re: [Qemu-devel] [RFC PATCH v0 2/9] cpu: Store CPU typename in MachineState, Eduardo Habkost, 2015/12/16
- Re: [Qemu-devel] [RFC PATCH v0 2/9] cpu: Store CPU typename in MachineState, Igor Mammedov, 2015/12/16
- Re: [Qemu-devel] [RFC PATCH v0 2/9] cpu: Store CPU typename in MachineState, Eduardo Habkost, 2015/12/17
- Re: [Qemu-devel] [RFC PATCH v0 2/9] cpu: Store CPU typename in MachineState, Igor Mammedov, 2015/12/18
- Re: [Qemu-devel] [RFC PATCH v0 2/9] cpu: Store CPU typename in MachineState, Eduardo Habkost, 2015/12/18
- Re: [Qemu-devel] [RFC PATCH v0 2/9] cpu: Store CPU typename in MachineState, Igor Mammedov, 2015/12/18
[Qemu-devel] [RFC PATCH v0 4/9] cpu: CPU socket backend, Bharata B Rao, 2015/12/10
[Qemu-devel] [RFC PATCH v0 6/9] cpu: Introduce CPU core device, Bharata B Rao, 2015/12/10