Re: [Qemu-devel] [PATCH] rtc: introduce nmi disable bit handler for cmos

[Paolo Bonzini]

On 14/12/2015 13:49, Gonglei (Arei) wrote:
>>> > > This patch introduce nmi disable bit handler to fix the problem and
>>> > > make the emulated CMOS like the real hardware.
>> > 
>> > I think that this only works with -machine kernel_irqchip=off, however.
> IIRCC, the kernel_irqchip is disabled by default, and we used the default 
> value.

No, it's enabled by default.

> >  You would have to add a new bit to struct kvm_vcpu_events, which could for
> > example replace nmi.pad.
> 
> You mean we should keep the value of nmi_disabled when we want to live 
> migration?

Yes.  It can also be used to communicate the enabling/disabling of NMIs
when the RTC is written.

> > >  Please refer to:
> > >    https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg00616.html
> > >
> > >  Note: We can't reproduce the problem, what a pity :(  I holp the
> > > patch can fix it. Please review, thanks!
> > 
> > The effect of the patch could be tested with kvm-unit-tests.
> 
> I'll test this version with kvm-unit-tests.

Note that you'll have to write a new test. :)

Paolo