[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 3/7] vmxnet3: Introduce 'x-old-msi-offsets' b
From: |
Jason Wang |
Subject: |
Re: [Qemu-devel] [PATCH v3 3/7] vmxnet3: Introduce 'x-old-msi-offsets' backword compatability property |
Date: |
Mon, 14 Dec 2015 14:21:39 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 12/12/2015 08:00 PM, Shmulik Ladkani wrote:
> Following the previous patches, where vmxnet3's pci's msi/msix
> capability offsets and msix's PBA table offsets have been changed, this
> patch introduces a boolean property 'x-old-msi-offsets' to vmxnet3,
> whose default is false.
>
> Setting 'x-old-msi-offsets' to 'on' preserves the old offsets behavior,
> which allows migration to older versions.
>
> Signed-off-by: Shmulik Ladkani <address@hidden>
> ---
> hw/net/vmxnet3.c | 2 ++
> include/hw/compat.h | 4 ++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
> index 97f0aea..d1fe888 100644
> --- a/hw/net/vmxnet3.c
> +++ b/hw/net/vmxnet3.c
> @@ -2564,6 +2564,8 @@ static const VMStateDescription vmstate_vmxnet3 = {
>
> static Property vmxnet3_properties[] = {
> DEFINE_NIC_PROPERTIES(VMXNET3State, conf),
> + DEFINE_PROP_BIT("x-old-msi-offsets", VMXNET3State, compat_flags,
> + VMXNET3_COMPAT_FLAG_OLD_MSI_OFFSETS_BIT, false),
> DEFINE_PROP_END_OF_LIST(),
> };
>
> diff --git a/include/hw/compat.h b/include/hw/compat.h
> index d0b1c4f..01e326d 100644
> --- a/include/hw/compat.h
> +++ b/include/hw/compat.h
> @@ -18,6 +18,10 @@
> .driver = "virtio-pci",\
> .property = "migrate-extra",\
> .value = "off",\
> + },{\
> + .driver = "vmxnet3",\
> + .property = "x-old-msi-offsets",\
> + .value = "on",\
> },
>
> #define HW_COMPAT_2_3 \
Too late for 2.5. Need to do this for 2.6, so we probably want either
introduce 2.6 machine type by yourself or wait for somebody else to do
it and do it for HW_COMPAT_2_5 :)
- [Qemu-devel] [PATCH v3 0/7] vmxnet3: Fine-tune device capabilities, Shmulik Ladkani, 2015/12/12
- [Qemu-devel] [PATCH v3 1/7] vmxnet3: Change offsets of msi/msix pci capabilities, Shmulik Ladkani, 2015/12/12
- [Qemu-devel] [PATCH v3 2/7] vmxnet3: Change the offset of the MSIX PBA table, Shmulik Ladkani, 2015/12/12
- [Qemu-devel] [PATCH v3 3/7] vmxnet3: Introduce 'x-old-msi-offsets' backword compatability property, Shmulik Ladkani, 2015/12/12
- Re: [Qemu-devel] [PATCH v3 3/7] vmxnet3: Introduce 'x-old-msi-offsets' backword compatability property,
Jason Wang <=
- [Qemu-devel] [PATCH v3 4/7] vmxnet3: coding: Introduce VMXNET3Class, Shmulik Ladkani, 2015/12/12
- [Qemu-devel] [PATCH v3 6/7] vmxnet3: Introduce 'x-disable-pcie' backword compatability property, Shmulik Ladkani, 2015/12/12
- [Qemu-devel] [PATCH v3 5/7] vmxnet3: The vmxnet3 device is a PCIE endpoint, Shmulik Ladkani, 2015/12/12
[Qemu-devel] [PATCH v3 7/7] vmxnet3: Report the Device Serial Number capability, Shmulik Ladkani, 2015/12/12