Re: [Qemu-devel] [PATCH] fix:readcapacity 10 failure shown even 16 sent

[Zhu Lingshan]

Yeah, I assume that is an easy and efficient solution

Thanks

On 12/10/2015 04:57 PM, Peter Lieven wrote:
> Am 10.12.2015 um 09:55 schrieb Paolo Bonzini:
> > On 10/12/2015 03:59, Zhu Lingshan wrote:
> > > -    if (task == NULL || task->status != SCSI_STATUS_GOOD) {
> > > +    if ((rc16 != NULL) && ((task == NULL) || (task->status != 
> > > SCSI_STATUS_GOOD))) {
> > > +        error_setg(errp, "iSCSI: failed to send readcapacity16 
> > > command.");
> > > +    }
> > You need an "else" here.
>
> rc16 can't be not NULL if task is NULL.
>
> I would not spent to much energie here and just adjust the error 
> message to
>
> "iSCSI: failed to send readcapacity10/16 command."
>
> Peter