Re: [Qemu-devel] [PATCH 16/74] acpi: add aml_lor()

[Marcel Apfelbaum]

On 12/10/2015 01:41 AM, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
>   hw/acpi/aml-build.c         | 9 +++++++++
>   include/hw/acpi/aml-build.h | 1 +
>   2 files changed, 10 insertions(+)
>
> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
> index 5094826..8cfa65c 100644
> --- a/hw/acpi/aml-build.c
> +++ b/hw/acpi/aml-build.c
> @@ -484,6 +484,15 @@ Aml *aml_or(Aml *arg1, Aml *arg2)
>       return build_opcode_2arg_dst(0x7D /* OrOp */, arg1, arg2, NULL);
>   }
>
> +/* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefLOr */
> +Aml *aml_lor(Aml *arg1, Aml *arg2)
> +{
> +    Aml *var = aml_opcode(0x91 /* LOrOp */);
> +    aml_append(var, arg1);
> +    aml_append(var, arg2);
> +    return var;
> +}
> +
>   /* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefShiftLeft */
>   Aml *aml_shiftleft(Aml *arg1, Aml *count)
>   {
> diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
> index cd82065..897e093 100644
> --- a/include/hw/acpi/aml-build.h
> +++ b/include/hw/acpi/aml-build.h
> @@ -208,6 +208,7 @@ Aml *aml_to_integer(Aml *arg);
>   Aml *aml_store(Aml *val, Aml *target);
>   Aml *aml_and(Aml *arg1, Aml *arg2);
>   Aml *aml_or(Aml *arg1, Aml *arg2);
> +Aml *aml_lor(Aml *arg1, Aml *arg2);
>   Aml *aml_shiftleft(Aml *arg1, Aml *count);
>   Aml *aml_shiftright(Aml *arg1, Aml *count, Aml *dst);
>   Aml *aml_lless(Aml *arg1, Aml *arg2);

Reviewed-by: Marcel Apfelbaum <address@hidden>