qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 12/74] acpi: extend aml_shiftright() to accept t


From: Marcel Apfelbaum
Subject: Re: [Qemu-devel] [PATCH 12/74] acpi: extend aml_shiftright() to accept target argument
Date: Thu, 10 Dec 2015 15:08:14 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0

On 12/10/2015 01:41 AM, Igor Mammedov wrote:
it allows to express ShiftRight(A,B,C) syntax

Signed-off-by: Igor Mammedov <address@hidden>
---
  hw/acpi/aml-build.c         | 4 ++--
  hw/i386/acpi-build.c        | 2 +-
  include/hw/acpi/aml-build.h | 2 +-
  3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
index 1f599e3..dcaa7e9 100644
--- a/hw/acpi/aml-build.c
+++ b/hw/acpi/aml-build.c
@@ -491,9 +491,9 @@ Aml *aml_shiftleft(Aml *arg1, Aml *count)
  }

  /* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefShiftRight */
-Aml *aml_shiftright(Aml *arg1, Aml *count)
+Aml *aml_shiftright(Aml *arg1, Aml *count, Aml *dst)
  {
-    return build_opcode_2arg_dst(0x7A /* ShiftRightOp */, arg1, count, NULL);
+    return build_opcode_2arg_dst(0x7A /* ShiftRightOp */, arg1, count, dst);
  }

  /* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefLLess */
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index bce0252..8f7b95a 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -666,7 +666,7 @@ static Aml *build_prt(void)

          /* slot = pin >> 2 */
          aml_append(while_ctx,
-                   aml_store(aml_shiftright(pin, aml_int(2)), slot));
+                   aml_store(aml_shiftright(pin, aml_int(2), NULL), slot));
          /* lnk_idx = (slot + pin) & 3 */
          aml_append(while_ctx,
              aml_store(aml_and(aml_add(pin, slot, NULL), aml_int(3)), 
lnk_idx));
diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
index d28bfe6..a694a67 100644
--- a/include/hw/acpi/aml-build.h
+++ b/include/hw/acpi/aml-build.h
@@ -203,7 +203,7 @@ Aml *aml_store(Aml *val, Aml *target);
  Aml *aml_and(Aml *arg1, Aml *arg2);
  Aml *aml_or(Aml *arg1, Aml *arg2);
  Aml *aml_shiftleft(Aml *arg1, Aml *count);
-Aml *aml_shiftright(Aml *arg1, Aml *count);
+Aml *aml_shiftright(Aml *arg1, Aml *count, Aml *dst);
  Aml *aml_lless(Aml *arg1, Aml *arg2);
  Aml *aml_add(Aml *arg1, Aml *arg2, Aml *dst);
  Aml *aml_subtract(Aml *arg1, Aml *arg2, Aml *dst);


Reviewed-by: Marcel Apfelbaum <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]