qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 06/74] acpi: add aml_create_qword_field()


From: Marcel Apfelbaum
Subject: Re: [Qemu-devel] [PATCH 06/74] acpi: add aml_create_qword_field()
Date: Thu, 10 Dec 2015 14:53:29 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0

On 12/10/2015 01:41 AM, Igor Mammedov wrote:
Signed-off-by: Igor Mammedov <address@hidden>
---
  hw/acpi/aml-build.c         | 21 +++++++++++++++++----
  include/hw/acpi/aml-build.h |  1 +
  2 files changed, 18 insertions(+), 4 deletions(-)

diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
index bb2c9f7..a6e4c54 100644
--- a/hw/acpi/aml-build.c
+++ b/hw/acpi/aml-build.c
@@ -805,17 +805,30 @@ Aml *aml_field(const char *name, AmlAccessType type, 
AmlUpdateRule rule)
      return var;
  }

-/* ACPI 1.0b: 16.2.5.2 Named Objects Encoding: DefCreateDWordField */
-Aml *aml_create_dword_field(Aml *srcbuf, Aml *index, const char *name)
+static
+Aml *create_field_common(int opcode, Aml *srcbuf, Aml *index, const char *name)
  {
-    Aml *var = aml_alloc();
-    build_append_byte(var->buf, 0x8A); /* CreateDWordFieldOp */
+    Aml *var = aml_opcode(opcode);
      aml_append(var, srcbuf);
      aml_append(var, index);
      build_append_namestring(var->buf, "%s", name);
      return var;
  }

+/* ACPI 1.0b: 16.2.5.2 Named Objects Encoding: DefCreateDWordField */
+Aml *aml_create_dword_field(Aml *srcbuf, Aml *index, const char *name)
+{
+    return create_field_common(0x8A /* CreateDWordFieldOp */,
+                               srcbuf, index, name);
+}
+
+/* ACPI 2.0a: 17.2.4.2 Named Objects Encoding: DefCreateQWordField */
+Aml *aml_create_qword_field(Aml *srcbuf, Aml *index, const char *name)
+{
+    return create_field_common(0x8F /* CreateQWordFieldOp */,
+                               srcbuf, index, name);
+}
+
  /* ACPI 1.0b: 16.2.3 Data Objects Encoding: String */
  Aml *aml_string(const char *name_format, ...)
  {
diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
index b220b12..c113b17 100644
--- a/include/hw/acpi/aml-build.h
+++ b/include/hw/acpi/aml-build.h
@@ -275,6 +275,7 @@ Aml *aml_mutex(const char *name, uint8_t sync_level);
  Aml *aml_acquire(Aml *mutex, uint16_t timeout);
  Aml *aml_release(Aml *mutex);
  Aml *aml_create_dword_field(Aml *srcbuf, Aml *index, const char *name);
+Aml *aml_create_qword_field(Aml *srcbuf, Aml *index, const char *name);
  Aml *aml_varpackage(uint32_t num_elements);
  Aml *aml_touuid(const char *uuid);
  Aml *aml_unicode(const char *str);


Reviewed-by: Marcel Apfelbaum <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]