[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/12] arm_mptimer: Don't use hw_error() in real
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 03/12] arm_mptimer: Don't use hw_error() in realize() method |
Date: |
Thu, 10 Dec 2015 10:37:51 +0000 |
On 10 December 2015 at 10:29, Markus Armbruster <address@hidden> wrote:
> Device realize() methods aren't supposed to call hw_error(), they
> should set an error and fail cleanly. Do that.
>
> Cc: Peter Maydell <address@hidden>
> Cc: address@hidden
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> hw/timer/arm_mptimer.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/timer/arm_mptimer.c b/hw/timer/arm_mptimer.c
> index 3e59c2a..f1a34ec 100644
> --- a/hw/timer/arm_mptimer.c
> +++ b/hw/timer/arm_mptimer.c
> @@ -220,8 +220,9 @@ static void arm_mptimer_realize(DeviceState *dev, Error
> **errp)
> int i;
>
> if (s->num_cpu < 1 || s->num_cpu > ARM_MPTIMER_MAX_CPUS) {
> - hw_error("%s: num-cpu must be between 1 and %d\n",
> - __func__, ARM_MPTIMER_MAX_CPUS);
> + error_setg(errp, "num-cpu must be between 1 and %d\n",
> + ARM_MPTIMER_MAX_CPUS);
> + return;
I think the trailing newline is incorrect for error_setg, right?
Otherwise
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- [Qemu-devel] [PATCH 02/12] omap: Don't use hw_error() in device init() methods, (continued)
- [Qemu-devel] [PATCH 02/12] omap: Don't use hw_error() in device init() methods, Markus Armbruster, 2015/12/10
- [Qemu-devel] [PATCH 04/12] etraxfs_eth: Don't use hw_error() in init() method, Markus Armbruster, 2015/12/10
- [Qemu-devel] [PATCH 01/12] hw: Don't use hw_error() for machine initialization errors, Markus Armbruster, 2015/12/10
- [Qemu-devel] [PATCH 03/12] arm_mptimer: Don't use hw_error() in realize() method, Markus Armbruster, 2015/12/10
- Re: [Qemu-devel] [PATCH 03/12] arm_mptimer: Don't use hw_error() in realize() method,
Peter Maydell <=
- [Qemu-devel] [PATCH 06/12] hw/arm/virt: Fix property "gic-version" error handling, Markus Armbruster, 2015/12/10
- [Qemu-devel] [PATCH 11/12] audio: Clean up inappropriate and unreachable use of hw_error(), Markus Armbruster, 2015/12/10
- [Qemu-devel] [PATCH 07/12] sysbus: Don't use hw_error() in machine_init_done_notifiers, Markus Armbruster, 2015/12/10
- [Qemu-devel] [PATCH 12/12] xen-hvm: Mark inappropriate error handling FIXME, Markus Armbruster, 2015/12/10
- [Qemu-devel] [PATCH 09/12] isa: Clean up error handling around isa_bus_new(), Markus Armbruster, 2015/12/10