[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.6 v2 04/10] fdc: add default drive type op
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH for-2.6 v2 04/10] fdc: add default drive type option |
Date: |
Mon, 7 Dec 2015 16:56:13 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 12/07/2015 04:34 PM, John Snow wrote:
> This patch adds a new explicit Floppy Drive Type option. The existing
> behavior in QEMU is to automatically guess a drive type based on the
> media inserted, or if a diskette is not present, arbitrarily assign one.
>
> This behavior can be described as "auto." This patch adds explicit
> behaviors: 120, 144, 288, auto, and none. The new "auto" behavior
> is intended to mimick current behavior, while the other types pick
s/mimick/mimic/ (one of those weird 'ic' verbs where the 'k' is
necessary in past tense but not present tense)
> one explicitly.
>
> In a future patch, the goal is to change the FDC's default drive type
> from auto (falling back to 1.44MB) to auto (falling back to 2.88MB).
>
> In order to allow users to obtain the old behaviors, though, a mechanism
> for specifying the exact type of drive we want is needed.
>
> This patch adds the properties, but it is not acted on yet in favor of
> making those changes a little more explicitly clear in standalone patches
> later in this patch set.
>
> Signed-off-by: John Snow <address@hidden>
> ---
> +++ b/qapi/block.json
> @@ -40,6 +40,22 @@
> 'data': ['auto', 'none', 'lba', 'large', 'rechs']}
>
> ##
> +# @FloppyDriveType
> +#
> +# Type of Floppy drive to be emulated by the Floppy Disk Controller.
> +#
> +# @144: 1.44MB 3.5" drive
> +# @288: 2.88MB 3.5" drive
> +# @120: 1.5MB 5.25" drive
Names start with a digit - not the prettiest, but also not the first
instance, so qapi handles it just fine. And I don't have any
suggestions for a better yet still concise name.
> +# @none: No drive connected
> +# @auto: Automatically determined by inserted media at boot
> +#
> +# Since: 2.6
> +##
> +{ 'enum': 'FloppyDriveType',
> + 'data': ['144', '288', '120', 'none', 'auto']}
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH for-2.6 v2 00/10] fdc: fix 2.88mb floppy diskette support, John Snow, 2015/12/07
- [Qemu-devel] [PATCH for-2.6 v2 03/10] fdc: add disk field, John Snow, 2015/12/07
- [Qemu-devel] [PATCH for-2.6 v2 02/10] fdc: refactor pick_geometry, John Snow, 2015/12/07
- [Qemu-devel] [PATCH for-2.6 v2 05/10] fdc: do not call revalidate on eject, John Snow, 2015/12/07
- [Qemu-devel] [PATCH for-2.6 v2 07/10] fdc: add physical disk sizes, John Snow, 2015/12/07
- [Qemu-devel] [PATCH for-2.6 v2 04/10] fdc: add default drive type option, John Snow, 2015/12/07
- Re: [Qemu-devel] [PATCH for-2.6 v2 04/10] fdc: add default drive type option,
Eric Blake <=
- [Qemu-devel] [PATCH for-2.6 v2 08/10] fdc: rework pick_geometry, John Snow, 2015/12/07
- [Qemu-devel] [PATCH for-2.6 v2 01/10] fdc: move pick_geometry, John Snow, 2015/12/07
- [Qemu-devel] [PATCH for-2.6 v2 06/10] fdc: implement new drive type property, John Snow, 2015/12/07
- [Qemu-devel] [PATCH for-2.6 v2 09/10] qtest/fdc: Support for 2.88MB drives, John Snow, 2015/12/07
- [Qemu-devel] [PATCH for-2.6 v2 10/10] fdc: change auto fallback drive to 288, John Snow, 2015/12/07