[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL for-2.5 1/4] iothread: include id in thread name
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PULL for-2.5 1/4] iothread: include id in thread name |
Date: |
Mon, 7 Dec 2015 10:58:35 +0100 |
On Thu, 3 Dec 2015 12:59:59 +0800
Stefan Hajnoczi <address@hidden> wrote:
> From: Paolo Bonzini <address@hidden>
>
> This makes it easier to find the desired thread. Use "IO" plus the id;
> even with the 14 character limit on the thread name, enough of the id should
> be readable (e.g. "IO iothreadNNN" with three characters for the number).
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> Message-id: address@hidden
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> iothread.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/iothread.c b/iothread.c
> index da6ce7b..1b8c2bb 100644
> --- a/iothread.c
> +++ b/iothread.c
> @@ -72,6 +72,7 @@ static void iothread_complete(UserCreatable *obj, Error
> **errp)
> {
> Error *local_error = NULL;
> IOThread *iothread = IOTHREAD(obj);
> + char *name, *thread_name;
>
> iothread->stopping = false;
> iothread->thread_id = -1;
> @@ -87,8 +88,12 @@ static void iothread_complete(UserCreatable *obj, Error
> **errp)
> /* This assumes we are called from a thread with useful CPU affinity for
> us
> * to inherit.
> */
> - qemu_thread_create(&iothread->thread, "iothread", iothread_run,
> + name = object_get_canonical_path_component(OBJECT(obj));
This one breaks x-data-plane:
... -device virtio-blk-ccw,x-data-plane=true ...
ERROR:/data/git/yyy/qemu/qom/object.c:1515:object_get_canonical_path_component:
assertion failed: (obj->parent != NULL)
> + thread_name = g_strdup_printf("IO %s", name);
> + qemu_thread_create(&iothread->thread, thread_name, iothread_run,
> iothread, QEMU_THREAD_JOINABLE);
> + g_free(thread_name);
> + g_free(name);
>
> /* Wait for initialization to complete */
> qemu_mutex_lock(&iothread->init_done_lock);
- [Qemu-devel] [PULL for-2.5 0/4] Block patches, Stefan Hajnoczi, 2015/12/03
- [Qemu-devel] [PULL for-2.5 1/4] iothread: include id in thread name, Stefan Hajnoczi, 2015/12/03
- Re: [Qemu-devel] [PULL for-2.5 1/4] iothread: include id in thread name,
Cornelia Huck <=
- [Qemu-devel] [PULL for-2.5 2/4] block: Don't wait serialising for non-COR read requests, Stefan Hajnoczi, 2015/12/03
- Re: [Qemu-devel] [PULL for-2.5 2/4] block: Don't wait serialising for non-COR read requests, Cornelia Huck, 2015/12/07
- Re: [Qemu-devel] [PULL for-2.5 2/4] block: Don't wait serialising for non-COR read requests, Cornelia Huck, 2015/12/07
- Re: [Qemu-devel] [PULL for-2.5 2/4] block: Don't wait serialising for non-COR read requests, Fam Zheng, 2015/12/07
- Re: [Qemu-devel] [PULL for-2.5 2/4] block: Don't wait serialising for non-COR read requests, Kevin Wolf, 2015/12/08
- Re: [Qemu-devel] [PULL for-2.5 2/4] block: Don't wait serialising for non-COR read requests, Cornelia Huck, 2015/12/08
- Re: [Qemu-devel] [PULL for-2.5 2/4] block: Don't wait serialising for non-COR read requests, Christian Borntraeger, 2015/12/08
- Re: [Qemu-devel] [PULL for-2.5 2/4] block: Don't wait serialising for non-COR read requests, Christian Borntraeger, 2015/12/08
- Re: [Qemu-devel] [PULL for-2.5 2/4] block: Don't wait serialising for non-COR read requests, Kevin Wolf, 2015/12/08
- Re: [Qemu-devel] [PULL for-2.5 2/4] block: Don't wait serialising for non-COR read requests, Christian Borntraeger, 2015/12/08