[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/13] acpi: Make piix-specific and q35-specific
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH 00/13] acpi: Make piix-specific and q35-specific code generic |
Date: |
Thu, 3 Dec 2015 15:16:21 -0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Dec 03, 2015 at 04:19:19PM +0100, Igor Mammedov wrote:
> On Wed, 2 Dec 2015 20:22:45 -0200
> Eduardo Habkost <address@hidden> wrote:
>
> > This series removes piix-specific and q35-specific code from
> > acpi-build.c, making it generic and without direct dependencies
> > to piix and q35 code.
> we are conflicting reshuffling acpi-build.c at the same time
> could be cleanup done on top of my refactoring
> drop_ASL_support_v1 branch:
>
> https://github.com/imammedo/qemu/commits/drop_ASL_support_v1
Do you plan to submit it soon?
It looks like my series and yours go in opposite directions. I am
trying to remove piix4-specific code from acpi-build, and you are
addding a is_piix4 field to AcpiMiscInfo. Your series makes much
more difficult to remove piix4-specific code from acpi-build.c,
but this sounds like a reasonable price for moving the dsdt.dsl
logic to C. Maybe I should change my goal from "removing
piix4-specific code" to just simplifying the code.
I will redo this series on top of yours, taking that into
account.
There are a few conflicts with the other series, but they are
very easy to solve:
> > This series needs to be applied after the following:
> > * [PATCH v3 0/6] pc: Initialization and compat function cleanup
No conflicts.
> > * [PATCH V3 0/3] hw/pcie: Multi-root support for Q35
Trivial conflict at crs_range_merge().
> > * [PATCH 00/16] pc: Eliminate struct PcGuestInfo
Simple conflict at build_ssdt().
--
Eduardo
- [Qemu-devel] [PATCH 05/13] acpi: Simplify s3/s4 property querying, (continued)
- [Qemu-devel] [PATCH 05/13] acpi: Simplify s3/s4 property querying, Eduardo Habkost, 2015/12/03
- [Qemu-devel] [PATCH 06/13] acpi: Use &error_abort when getting PCI hotplug properties, Eduardo Habkost, 2015/12/03
- [Qemu-devel] [PATCH 07/13] acpi: Use QOM property to get CPU hotplug I/O base, Eduardo Habkost, 2015/12/03
- [Qemu-devel] [PATCH 08/13] acpi: Always try to init PCI hotplug I/O base, Eduardo Habkost, 2015/12/03
- [Qemu-devel] [PATCH 10/13] acpi: Change acpi_pci_hotplug_enabled() argument to PCMachineState, Eduardo Habkost, 2015/12/03
- [Qemu-devel] [PATCH 09/13] acpi: Use PCMachineState::acpi_dev to get ACPI dev, Eduardo Habkost, 2015/12/03
- [Qemu-devel] [PATCH 12/13] intel_iommu.h: Missing sysbus.h include, Eduardo Habkost, 2015/12/03
- [Qemu-devel] [PATCH 11/13] acpi: Don't use find_i440fx() when setting bsel properties, Eduardo Habkost, 2015/12/03
- [Qemu-devel] [PATCH 13/13] acpi: Don't include q35 and piix headers, Eduardo Habkost, 2015/12/03
- Re: [Qemu-devel] [PATCH 00/13] acpi: Make piix-specific and q35-specific code generic, Igor Mammedov, 2015/12/03
- Re: [Qemu-devel] [PATCH 00/13] acpi: Make piix-specific and q35-specific code generic,
Eduardo Habkost <=