Re: [Qemu-devel] [PATCH 01/13] hbitmap: serialization

[Vladimir Sementsov-Ogievskiy]

On 03.12.2015 10:35, Fam Zheng wrote:
> On Wed, 11/11 18:16, Vladimir Sementsov-Ogievskiy wrote:
> > +void hbitmap_deserialize_finish(HBitmap *bitmap)
> > +{
> > +    int64_t i, size, prev_size;
> > +    int lev;
> > +
> > +    /* restore levels starting from penultimate to zero level, assuming
> > +     * that the last level is ok */
> > +    size = MAX((bitmap->size + BITS_PER_LONG - 1) >> BITS_PER_LEVEL, 1);
> > +    for (lev = HBITMAP_LEVELS - 1; lev-- > 0; ) {
> > +        prev_size = size;
> > +        size = MAX((size + BITS_PER_LONG - 1) >> BITS_PER_LEVEL, 1);
> > +        memset(bitmap->levels[lev], 0, size * sizeof(unsigned long));
> > +
> > +        for (i = 0; i < prev_size; ++i) {
> > +            if (bitmap->levels[lev + 1][i]) {
> > +                bitmap->levels[lev][i >> BITS_PER_LEVEL] |=
> > +                    1 << (i & (BITS_PER_LONG - 1));
> This should be 1UL.

Yes, I've found it yesterday.. with two days of debugging)

> Fam
>
> > +            }
> > +        }
> > +    }
> > +
> > +    bitmap->levels[0][0] |= 1UL << (BITS_PER_LONG - 1);
> > +}
> > +
> >   void hbitmap_free(HBitmap *hb)
> >   {
> >       unsigned i;
> > --
> > 2.1.4


--
Best regards,
Vladimir
* now, @virtuozzo.com instead of @parallels.com. Sorry for this inconvenience.