Re: [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED

[Eric Blake]

On 12/02/2015 08:21 AM, Peter Xu wrote:
> On Wed, Dec 02, 2015 at 07:45:52AM -0700, Eric Blake wrote:
>> On 12/01/2015 06:11 PM, Fam Zheng wrote:
>>> Please explicitly mention that successful dump emits DUMP_COMPLETED without
>>> error, and failed dump emits DUMP_COMPLETED that has an error str.
>>
>> In fact, I wonder if it would also be worth having a
>> 'status':'DumpStatus' field, which records the final status of the dump
>> (either 'completed' or 'failed'), and which is always present.
> 
> Will the raw memory total size useful in any way? I am totally ok to
> add this, just failed to find a way for user to use it besides
> calculating finished work during dump... :(

Good idea.  You never know if it will be helpful, but the information is
basically free to provide and doesn't seem like too much of a
maintenance burden to promise to always include the total.  And in the
case of an error, knowing the final values of complete/total might also
be useful to see how far things got before failure (for example, if it
failed because of ENOSPACE, knowing how much was complete may give an
idea of how much additional space should be added before retrying).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature