[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [for-2.6 PATCH 0/3] target-i386: Use C struct for xsave
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [for-2.6 PATCH 0/3] target-i386: Use C struct for xsave area layout, offsets & sizes |
Date: |
Mon, 30 Nov 2015 12:14:59 -0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Nov 30, 2015 at 12:21:23PM +0100, Paolo Bonzini wrote:
>
>
> On 28/11/2015 20:56, Eduardo Habkost wrote:
> > I still need to figure out a way to write unit tests for the new
> > code. Maybe I will just copy and paste the new and old functions,
> > and test them locally (checking if they give the same results
> > when translating blobs of random bytes).
>
> Aren't the QEMU_BUILD_BUG_ON enough? No need to delete them in patch 3,
> though perhaps you can remove the #defines.
Just wanted to be 100% sure. Even if the offets are all correct,
I might have made other mistakes when translating the get/save
code.
About the QEMU_BUILD_BUG_ON lines, we can keep them if you like.
We could translate the uint32_t offsets to byte offsets after
ptach 3/3, to make them easier to compare to the Intel docs.
--
Eduardo
- [Qemu-devel] [for-2.6 PATCH 0/3] target-i386: Use C struct for xsave area layout, offsets & sizes, Eduardo Habkost, 2015/11/28
- [Qemu-devel] [for-2.6 PATCH 1/3] target-i386: Define structs for layout of xsave area, Eduardo Habkost, 2015/11/28
- [Qemu-devel] [for-2.6 PATCH 2/3] target-i386: Use xsave structs for ext_save_area, Eduardo Habkost, 2015/11/28
- [Qemu-devel] [for-2.6 PATCH 3/3] target-i386: kvm: Use X86XSaveArea struct for xsave save/load, Eduardo Habkost, 2015/11/28
- Re: [Qemu-devel] [for-2.6 PATCH 0/3] target-i386: Use C struct for xsave area layout, offsets & sizes, Paolo Bonzini, 2015/11/30
- Re: [Qemu-devel] [for-2.6 PATCH 0/3] target-i386: Use C struct for xsave area layout, offsets & sizes,
Eduardo Habkost <=