[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/8] dump-guest-memory: add qmp event DUMP_CO
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/8] dump-guest-memory: add qmp event DUMP_COMPLETED |
Date: |
Fri, 27 Nov 2015 14:43:43 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 11/27/2015 01:19 PM, Fam Zheng wrote:
> On Fri, 11/27 10:48, Peter Xu wrote:
>> @@ -1659,8 +1660,17 @@ static void dump_process(DumpState *s, Error **errp)
>> static void *dump_thread(void *data)
>> {
>> GlobalDumpState *global = (GlobalDumpState *)data;
>> - dump_process(global->gds_cur, NULL);
>> + Error *local_err = NULL;
>> + const char *msg = "Dump completed successfully";
>> +
>> + dump_process(global->gds_cur, &local_err);
>> dump_state_release(global);
>> +
>> + /* if detach is used, notify user that dump has finished */
>> + if (local_err) {
>> + msg = error_get_pretty(local_err);
>
> error_free?
Yes, thanks!
Peter
>
>
>> + }
>> + qapi_event_send_dump_completed(msg, &error_abort);
>> return NULL;
>> }
>>
Re: [Qemu-devel] [PATCH v2 3/8] dump-guest-memory: add basic "detach" support., Paolo Bonzini, 2015/11/27
[Qemu-devel] [PATCH v2 4/8] dump-guest-memory: add qmp event DUMP_COMPLETED, Peter Xu, 2015/11/26
[Qemu-devel] [PATCH v2 5/8] dump-query: add "dump-query" command to query dump status, Peter Xu, 2015/11/26
Re: [Qemu-devel] [PATCH v2 5/8] dump-query: add "dump-query" command to query dump status, Eric Blake, 2015/11/30