[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/4] Bitmap clean-up patches for 2.6
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/4] Bitmap clean-up patches for 2.6 |
Date: |
Thu, 26 Nov 2015 14:15:08 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, 11/25 09:57, Vladimir Sementsov-Ogievskiy wrote:
> Hmm, stop. Very bad thing (sorry, that I didn't realize it before):
>
> This breaks my dirty bitmap migration series with its meta bitmaps.
> Meta bitmap is an additional HBitmap in BdrvDirtyBitmap, which
> tracks dirtiness of this BdrvDirtyBitmap. And it (meta bitmap) have
> its own granularity of course. Or we will have to maintain
> additional meta_gran_shift and lots of duplicated code..
>
> If we speak about splitting granularity out of HBitmap, then the
> most true way should be
>
> struct HBitmapGranuled {
> struct HBitmap *hb;
> uint32_t gran_shift;
> }
>
> with all supporting functions and iterators.
Then it's not worth making this change, let's drop patch 3 & 4 for now.
Fam
- [Qemu-devel] [PATCH v3 0/4] Bitmap clean-up patches for 2.6, Fam Zheng, 2015/11/24
- [Qemu-devel] [PATCH v3 1/4] backup: Use Bitmap to replace "s->bitmap", Fam Zheng, 2015/11/24
- [Qemu-devel] [PATCH v3 2/4] block: Hide HBitmap in block dirty bitmap interface, Fam Zheng, 2015/11/24
- [Qemu-devel] [PATCH v3 3/4] block: Manage granularity in BdrvDirtyBitmap, Fam Zheng, 2015/11/24
- [Qemu-devel] [PATCH v3 4/4] hbitmap: Drop "granularity", Fam Zheng, 2015/11/24
- Re: [Qemu-devel] [PATCH v3 0/4] Bitmap clean-up patches for 2.6, Vladimir Sementsov-Ogievskiy, 2015/11/25
- Re: [Qemu-devel] [PATCH v3 0/4] Bitmap clean-up patches for 2.6,
Fam Zheng <=