|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH v2 for-2.5? 0/4] qjson: save a lot of memory |
Date: | Wed, 25 Nov 2015 19:08:41 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 25/11/2015 15:47, Markus Armbruster wrote: > > This patch from 2011 (!) saves about 96% of the allocation cost (down > > from 500 MiB to 20 MiB) for check-qjson. > > Looks good to me apart from the incomplete transition to recursive > descent in PATCH 2. I do not understand whether that is a problem. Is the remark from the commit message incorrect ("Saving the parser context is mostly unnecessary; we can replace it with peeking at the next token, or remove it altogether when the restore only happens on errors. The token list is destroyed anyway on errors.")? Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |