[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] numa: Clean up query-memdev error handling
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] numa: Clean up query-memdev error handling |
|
Date: |
Mon, 23 Nov 2015 12:44:04 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
"Michael S. Tsirkin" <address@hidden> writes:
> On Mon, Nov 23, 2015 at 09:35:31AM +0100, Markus Armbruster wrote:
>> qmp_query_memdev() has two error paths:
>>
>> * When object_get_objects_root() returns null. It never does, so
>> simply drop the useless error handling.
>>
>> * When query_memdev() fails. It leaks err then. But any failure
>> there is actually a programming error. Switch it to &error_abort,
>> and drop the useless error handling.
>>
>> Messed up in commit 76b5d85 "qmp: add query-memdev".
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>
>
> Post 2.5 right?
I don't mind. I meant v1 for 2.5, but we've since convinced ourselves
that errors can't happen, and the memory leak is only latent.