[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Assume madvise for (no)hugepage works
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH] Assume madvise for (no)hugepage works |
Date: |
Fri, 20 Nov 2015 11:26:33 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
"Dr. David Alan Gilbert (git)" <address@hidden> wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> madvise() returns EINVAL in the case of many failures, but also
> returns it in cases where the host kernel doesn't have THP enabled.
> Postcopy only really cares that THP is off before it detects faults,
> and turns it back on afterwards; so we're going to have
> to assume that if the madvise fails then the host just doesn't do
> THP and we can carry on with the postcopy.
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> Tested-by: Jason J. Herne <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>