[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/3] target-i386: add pkeys support for cpuid
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/3] target-i386: add pkeys support for cpuid handling |
Date: |
Wed, 18 Nov 2015 13:58:55 -0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Nov 18, 2015 at 10:20:15AM +0800, Huaitong Han wrote:
[...]
> @@ -408,6 +420,13 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS]
> = {
> .cpuid_reg = R_EBX,
> .tcg_features = TCG_7_0_EBX_FEATURES,
> },
> + [FEAT_7_0_ECX] = {
> + .feat_names = cpuid_7_0_ecx_feature_name,
> + .cpuid_eax = 7,
> + .cpuid_needs_ecx = true, .cpuid_ecx = 0,
> + .cpuid_reg = R_ECX,
> + .tcg_features = TCG_7_0_ECX_FEATURES,
> + },
The patch looks good, but when we add the feature names to
cpuid_7_0_ecx_feature_name, QEMU will consider them as
migratable, but they are truly migratable only after we add the
ext_save_areas entry.
We can fix this by moving cpuid_7_0_ecx_feature_name to patch 2/3
(or to a separate patch, to be applied after 2/3).
--
Eduardo
[Qemu-devel] [PATCH v3 2/3] target-i386: add pkeys support for xsave state handling, Huaitong Han, 2015/11/17
[Qemu-devel] [PATCH v3 3/3] target-i386: add pkeys support for vm migration, Huaitong Han, 2015/11/17
Re: [Qemu-devel] [PATCH v3 0/3] target-i386: add memory protection-key support, Eduardo Habkost, 2015/11/18